tflobbe commented on a change in pull request #1210: SOLR-14219 force
serialVersionUID of OverseerSolrResponse
URL: https://github.com/apache/lucene-solr/pull/1210#discussion_r373207189
##########
File path: solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponse.java
##########
@@ -26,7 +26,9 @@
import java.util.Objects;
public class OverseerSolrResponse extends SolrResponse {
-
+
+ private static final long serialVersionUID = 4721653044098960880L;
Review comment:
> It's possible (though I think unlikely*) that there are systems where the
previous (computed) value is different to 472165..., but the new computed value
(with the change to the class) would be different anyway
That's why I suggest that we revert the changes to the class
> On systems using the standard build, we can make the new class
backwards-compatible by adding serialVersionUID. It's guaranteed to be
incompatible for everyone if we don't.
But removing the changes in OverseerSolrResponse also fixes the
compatibility issue, for all cases in theory. For versions higher than 8.5, the
solution will be to move to Javabin. @andywebb1975, I proposed the other
approach in https://github.com/apache/lucene-solr/pull/1227. mind taking a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
