tflobbe commented on a change in pull request #1210: SOLR-14219 force
serialVersionUID of OverseerSolrResponse
URL: https://github.com/apache/lucene-solr/pull/1210#discussion_r371507235
##########
File path: solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponse.java
##########
@@ -26,7 +26,9 @@
import java.util.Objects;
public class OverseerSolrResponse extends SolrResponse {
-
+
+ private static final long serialVersionUID = 4721653044098960880L;
Review comment:
I agree, everything that uses java serialization should be setting a
serialVersionUID, my concern is that it may be too late now. I think you
discovered a bug with your test (thanks!), but I believe it's too late to add a
serialVersionUID now because for some users it could mean exactly the same as
if we'd had one before and now we are changing it.
Hopefully this won't be an issue once the serialization is in javabin and
the Java serialization part is removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
