andywebb1975 commented on a change in pull request #1210: SOLR-14219 force
serialVersionUID of OverseerSolrResponse
URL: https://github.com/apache/lucene-solr/pull/1210#discussion_r371717458
##########
File path: solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponse.java
##########
@@ -26,7 +26,9 @@
import java.util.Objects;
public class OverseerSolrResponse extends SolrResponse {
-
+
+ private static final long serialVersionUID = 4721653044098960880L;
Review comment:
hi Tomas,
I still think it'd be better to set the serialVersionUID. It's _possible_
(though I think unlikely*) that there are systems where the previous (computed)
value is different to `472165...`, but the new computed value (with the change
to the class) would be different anyway, so either way they'll see an
incompatibility. On systems using the standard build, we can make the new class
backwards-compatible by adding serialVersionUID. It's guaranteed to be
incompatible for everyone if we don't.
Andy
\* My reading of
https://docs.oracle.com/javase/7/docs/platform/serialization/spec/class.html is
that the computed UID is independent of the Java version, and that it should be
set to the previously-computed value in version 2+ of a class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
