tflobbe commented on a change in pull request #1210: SOLR-14219 force serialVersionUID of OverseerSolrResponse URL: https://github.com/apache/lucene-solr/pull/1210#discussion_r371362174
########## File path: solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponse.java ########## @@ -26,7 +26,9 @@ import java.util.Objects; public class OverseerSolrResponse extends SolrResponse { - + + private static final long serialVersionUID = 4721653044098960880L; Review comment: My understanding is that this number can actually vary depending on the compiler, so setting it to a specific value like this (expecting it to be number the class had in previous versions) may not work for everyone. Since the changes done in SOLR-14095 are just addition of static methods, maybe the better solution is to just revert them from OverseerSolrResponse and put them in some other util class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org