[
https://issues.apache.org/jira/browse/LUCENE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026807#comment-17026807
]
Erick Erickson commented on LUCENE-8656:
----------------------------------------
[~romseygeek] I'll make you a deal, a special one-time-only, limited-time offer
;)
If you figure out what should be done here with just FuzzyQuery, I'll handle
the javacc/queryparser ramifications. I see from the patch that you regenerated
the queryparsers then I suspect you ran into the can of worms with unused
imports and a lot of other junk. I've just (I hope completely) fixed up the
gradle version of the javacc task to automatically clean all that up.
But I've been leery of changing FuzzyQuery because I don't particularly
understand what the right thing to do is or the intent of the original
deprecations.
Or just tell me that the part of the patch that deals with FuzzyQuery is
correct and I'll just steal that part. What I'm looking for here is some
reassurance that changing FuzzyQuery as in this patch is acceptable since I
have no clue, the rest I can handle. And I have the changes you made to use for
hints...
Let me know.
> Deprecations in FuzzyQuery
> --------------------------
>
> Key: LUCENE-8656
> URL: https://issues.apache.org/jira/browse/LUCENE-8656
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Attachments: LUCENE-8656.patch
>
>
> FuzzyQuery has a static helper method that translates float similarity values
> into integer edit distances, only currently used by queryparsers. It has
> been deprecated since 4.0, but I think allowing query parsers to specify
> float similarities is actually fine - we should un-deprecate it, and just
> remove the deprecated float-valued defaultMinSimilarity member.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
