ErickErickson opened a new pull request #1226: LUCENE-9134 Port ant-regenerate tasks to Gradle build URL: https://github.com/apache/lucene-solr/pull/1226 I think this is the final version, I'll merge upstream over the weekend absent objections. The cleanup does three things: 1> makes it all compile 2> allows precommit to pass 3> fixes all the compiler warnings except deprecations. Which means that the "./gradlew assemble" produces clean output since the default lint settings don't report them except to say "there are some". This should reduce the frequency of people hand-editing these files. A couple of notes: 1> the deprecations warning are mostly from FuzzyQuery, from changes a long time ago and I don't have the energy to tackle that, it should be a separate JIRA anyway. 2> cast and unchecked SuppressWarnings are no longer necessary, you'll note they are missing. Instead of suppressing warnings, the cleanup code fixes the source. We're using Javacc 5.0 and compiling against Java 11, so until we upgrade JavaCC they should stay I think. 3> all precommit and tests pass under Ant as well as Gradle.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
