[
https://issues.apache.org/jira/browse/LUCENE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028910#comment-17028910
]
Erick Erickson commented on LUCENE-8656:
----------------------------------------
Thanks!
The base class CharStream is regenerated, but FastCharStream isn't AFAICT.
I've changed the build script to fix all the things that generate lint
warnings, see ./gradle/generation/javacc.gradle in hopes that people won't feel
the need to hand-edit these in the future and let them get out of sync with the
generated code. So certainly if you notice anything in these areas that's not
right, let me know and I'll fix.
If you're curious, "./gradlew javacc" will run the regeneration of everything
in a few seconds (well, after the first run of the day). It's much less painful
than the ant target since it's now broken out into several tasks and you don't
get the humongous jflex task that takes 20G and 20 minutes unless you run the
"./gradle jflex" target.
I'll merge today...
> Deprecations in FuzzyQuery
> --------------------------
>
> Key: LUCENE-8656
> URL: https://issues.apache.org/jira/browse/LUCENE-8656
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Erick Erickson
> Priority: Major
> Attachments: LUCENE-8656.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> FuzzyQuery has a static helper method that translates float similarity values
> into integer edit distances, only currently used by queryparsers. It has
> been deprecated since 4.0, but I think allowing query parsers to specify
> float similarities is actually fine - we should un-deprecate it, and just
> remove the deprecated float-valued defaultMinSimilarity member.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
