[ https://issues.apache.org/jira/browse/LUCENE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028816#comment-17028816 ]
Alan Woodward commented on LUCENE-8656: --------------------------------------- +1 to your PR, thanks for picking this up [~erickerickson] The FastCharStream/CharStream deprecations are in generated code, I think, so I'm not entirely sure if adding them back in here is the correct thing to do, but I guess you're dealing with that via the other javacc changes? > Deprecations in FuzzyQuery > -------------------------- > > Key: LUCENE-8656 > URL: https://issues.apache.org/jira/browse/LUCENE-8656 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Erick Erickson > Priority: Major > Attachments: LUCENE-8656.patch > > Time Spent: 10m > Remaining Estimate: 0h > > FuzzyQuery has a static helper method that translates float similarity values > into integer edit distances, only currently used by queryparsers. It has > been deprecated since 4.0, but I think allowing query parsers to specify > float similarities is actually fine - we should un-deprecate it, and just > remove the deprecated float-valued defaultMinSimilarity member. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org