dsmiley commented on a change in pull request #1124: SOLR-14151 :Schema
components to be loadable from packages
URL: https://github.com/apache/lucene-solr/pull/1124#discussion_r361777990
##########
File path: solr/core/src/java/org/apache/solr/handler/SchemaHandler.java
##########
@@ -206,6 +206,10 @@ private void handleGET(SolrQueryRequest req,
SolrQueryResponse rsp) {
}
}
+ /**If a plugin is loaded from a package, the version of the package being
used should be added
Review comment:
minor: nor formatted well (and same goes for many other added javadocs)
I love the new comment though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
