[ https://issues.apache.org/jira/browse/SOLR-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935531#comment-16935531 ]
Ishan Chattopadhyaya commented on SOLR-13661: --------------------------------------------- [~janhoy], [~dsmiley], [~erickerickson], please review the design. Most of the class loader work is already done and committed as it was a standalone piece. The package management stuff resides in two public branches (SOLR-13722 and SOLR-13662) where Noble and I are collaborating. {quote}So my criteria is that nothing we do should make "the silent majority" of user's lives more difficult. {quote} [~erickerickson], This package management piece is going to be an opt-in and an optional feature. It will not get in the way of any conceivable existing user workflow (simple or complex). For those who will choose to use it, it will be a charm and their lives will never be the same again! {quote}I'm kind of sad to see this new JIRA not connecting to prior work at all, it should be a best practice to research prior art or at least ask on the list before starting a new Jira of this magnitude. {quote} [~janhoy] Initially, this work started with just trying to build the hot loading capabilities. That was independent of anything that we had in Solr, so Noble went ahead and committed that piece. As things progressed and I joined forces, the story evolved into building a complete package management system. In that pursuit, I did fully research your prior work. I asked you for the code https://issues.apache.org/jira/browse/SOLR-13661?focusedCommentId=16923943&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16923943, went over it fully. I find your sadness completely baseless. While I couldn't leverage your code piece directly, I borrowed the choice of your library (PF4J-update) and rolled it into a prototype (branch jira/solr-13662). {quote}I also don't like off-list development followed by huge code dumps in a rapid pace. {quote} All development happens off-list; they happen in our Git repository and referred to from our JIRA issues. Noble and I did exactly that: all code was available in a public JIRA branch on our main Apache repository, right from the day the code was ever written. The reason why you may have missed that is likely because pushes to those branches did not emit a JIRA comment. As for speed of development, "rapid" is cool ;) {quote}To be frank, I have a very hard time grasping the 10.000ft vision behind the current blob package effort, what the big picture is, how it will work our for users (small and large), and what about 3rd party plugin developers etc {quote} Fair concern; hopefully the latest document will address your concerns. The big picture remains the same as what you dreamed of; the eventual goal is for all of the extraneous features of Solr to sit as packages that users can install (from Apache repositories). A lite / safe Solr will be free from the optional features. However, this work will take time (I plan to start on the splitting up of Solr once the Gradle work is done). Meanwhile, the package manager will be immensely useful for 3rd party packages and repositories. {quote}I was also sad to see this new Jira get filed without any investigation / mention of previous efforts, and see a bunch of code fly in rapidly without review. Slightly angry/frustrated even. {quote} Cute! > A package management system for Solr > ------------------------------------ > > Key: SOLR-13661 > URL: https://issues.apache.org/jira/browse/SOLR-13661 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Noble Paul > Assignee: Ishan Chattopadhyaya > Priority: Major > Labels: package > Attachments: plugin-usage.png, repos.png > > > Here's the design doc: > https://docs.google.com/document/d/15b3m3i3NFDKbhkhX_BN0MgvPGZaBj34TKNF2-UNC3U8/edit?usp=sharing -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org