Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1027151462
##########
python/pyiceberg/expressions/literals.py:
##########
@@ -82,15 +76,15 @@ def to(self, type_var: IcebergType) -> Literal:
... # pragma: no cover
def __repr__(self) -> str:
- return f"{type(self).__name__}({self.value})"
+ return f"{type(self).__name__}({self.value!r})"
Review Comment:
Because mypy knows that it also can be `bytes`, it recommends adding the raw
option:
```
➜ python git:(fd-remove-dataclass) ✗ pre-commit run --all-files mypy
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1
python/pyiceberg/expressions/literals.py:79: error: On Python 3 formatting
"b'abc'" with "{}" produces "b'abc'", not "abc"; use "{!r}" if this is desired
behavior [str-bytes-safe]
```
##########
python/pyiceberg/expressions/__init__.py:
##########
@@ -40,36 +59,36 @@ def __invert__(self) -> BooleanExpression:
"""Transform the Expression into its negated version."""
-class Term(Generic[T], ABC):
+class Term(Generic[L], ABC):
"""A simple expression that evaluates to a value"""
class Bound(ABC):
"""Represents a bound value expression"""
-class Unbound(Generic[B], ABC):
+class Unbound(ABC):
"""Represents an unbound value expression"""
+ @property
@abstractmethod
- def bind(self, schema: Schema, case_sensitive: bool = True) -> B:
Review Comment:
Agreed, added it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
