Fokko commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1024523643
########## python/pyiceberg/expressions/__init__.py: ########## @@ -18,18 +18,37 @@ from __future__ import annotations from abc import ABC, abstractmethod -from dataclasses import dataclass from functools import reduce -from typing import ClassVar, Generic, TypeVar - -from pyiceberg.expressions.literals import Literal +from typing import ( + Any, + Generic, + Iterable, + Set, + Type, + Union, +) + +from pyiceberg.expressions.literals import Literal, literal from pyiceberg.files import StructProtocol from pyiceberg.schema import Accessor, Schema +from pyiceberg.typedef import L Review Comment: That is true, but I like the fact that we have all the bound types in one place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
