Fokko commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1024524963
########## python/tests/expressions/test_literals.py: ########## @@ -398,8 +397,8 @@ def test_fixed_literal(): def test_binary_literal(): - bin_lit012 = literal(bytearray([0x00, 0x01, 0x02])) - bin_lit013 = literal(bytearray([0x00, 0x01, 0x03])) + bin_lit012 = literal(bytes([0x00, 0x01, 0x02])) + bin_lit013 = literal(bytes([0x00, 0x01, 0x03])) Review Comment: I was able to achieve this using the `@overload` method, but that had other issues downstream. Personally I've always been using `bytes`, and you can easily cast a `bytearray` into `bytes`, so I think we're good here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
