Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1027151673
##########
python/pyiceberg/expressions/visitors.py:
##########
@@ -89,33 +91,33 @@ def visit_and(self, left_result: T, right_result: T) -> T:
"""Visit method for an And boolean expression
Args:
- left_result (T): The result of visiting the left side of the
expression
- right_result (T): The result of visiting the right side of the
expression
+ left_result (R): The result of visiting the left side of the
expression
+ right_result (R): The result of visiting the right side of the
expression
"""
@abstractmethod
def visit_or(self, left_result: T, right_result: T) -> T:
"""Visit method for an Or boolean expression
Args:
- left_result (T): The result of visiting the left side of the
expression
- right_result (T): The result of visiting the right side of the
expression
+ left_result (R): The result of visiting the left side of the
expression
+ right_result (R): The result of visiting the right side of the
expression
"""
@abstractmethod
- def visit_unbound_predicate(self, predicate) -> T:
+ def visit_unbound_predicate(self, predicate: UnboundPredicate) -> T:
Review Comment:
This is now possible again, indeed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
