Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1024536655
##########
python/pyiceberg/expressions/literals.py:
##########
@@ -53,24 +49,27 @@
UUIDType,
)
from pyiceberg.utils.datetime import (
- date_str_to_days,
+ date_str_to_date,
date_to_days,
- micros_to_days,
+ days_to_date,
+ micros_to_date,
Review Comment:
Removed :)
##########
python/pyiceberg/utils/datetime.py:
##########
@@ -38,6 +38,11 @@ def micros_to_days(timestamp: int) -> int:
return timedelta(microseconds=timestamp).days
+def micros_to_date(timestamp: int) -> date:
+ """Converts a timestamp in microseconds to a date"""
+ return days_to_date(timedelta(microseconds=timestamp).days)
Review Comment:
Removed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
