rdblue commented on code in PR #6073:
URL: https://github.com/apache/iceberg/pull/6073#discussion_r1014895355


##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -320,7 +321,10 @@ public <T extends RESTResponse> T handleRequest(
 
       case DROP_TABLE:
         {
-          CatalogHandlers.dropTable(catalog, identFromPathVars(vars));
+          CatalogHandlers.dropTable(
+              catalog,
+              identFromPathVars(vars),
+              PropertyUtil.propertyAsBoolean(vars, "purgeRequested", false));

Review Comment:
   I think this is correct for the REST API. If `purgeRequested` was not set 
then it was not requested. This should be consistent behavior, since purge 
would cause a failure before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to