rdblue commented on code in PR #6073:
URL: https://github.com/apache/iceberg/pull/6073#discussion_r1014894712


##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -799,6 +799,23 @@ public void testDropTable() {
     Assert.assertFalse("Table should not exist after drop", 
catalog.tableExists(TABLE));
   }
 
+  @Test
+  public void testDropTableWithPurge() {
+    C catalog = catalog();
+
+    if (requiresNamespaceCreate()) {
+      catalog.createNamespace(NS);
+    }
+
+    Assertions.assertThat(catalog.tableExists(TABLE)).isFalse();
+
+    catalog.buildTable(TABLE, SCHEMA).create();
+    Assertions.assertThat(catalog.tableExists(TABLE)).isTrue();
+
+    Assertions.assertThat(catalog.dropTable(TABLE, true)).isTrue();
+    Assertions.assertThat(catalog.tableExists(TABLE)).isFalse();

Review Comment:
   This looks copied from the test above. Can you copy the assertions with 
context strings?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to