[GitHub] [iceberg] nastra commented on a diff in pull request #6073: Core: Pass purgeRequested flag to REST server

[GitBox]

nastra commented on code in PR #6073:
URL: https://github.com/apache/iceberg/pull/6073#discussion_r1015101336


##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -799,6 +799,23 @@ public void testDropTable() {
     Assert.assertFalse("Table should not exist after drop", 
catalog.tableExists(TABLE));
   }
 
+  @Test
+  public void testDropTableWithPurge() {
+    C catalog = catalog();
+
+    if (requiresNamespaceCreate()) {
+      catalog.createNamespace(NS);
+    }
+
+    Assertions.assertThat(catalog.tableExists(TABLE)).isFalse();
+
+    catalog.buildTable(TABLE, SCHEMA).create();
+    Assertions.assertThat(catalog.tableExists(TABLE)).isTrue();
+
+    Assertions.assertThat(catalog.dropTable(TABLE, true)).isTrue();
+    Assertions.assertThat(catalog.tableExists(TABLE)).isFalse();

Review Comment:
   done



##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -222,13 +222,27 @@ public static LoadTableResponse createTable(
     throw new IllegalStateException("Cannot wrap catalog that does not produce 
BaseTable");
   }
 
+  /**
+   * @param catalog The catalog instance
+   * @param ident The table identifier of the table to be dropped.
+   * @deprecated Will be removed in 1.2.0, use {@link 
CatalogHandlers#dropTable(Catalog,
+   *     TableIdentifier, boolean)}.
+   */
+  @Deprecated

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org