rdblue commented on code in PR #6073: URL: https://github.com/apache/iceberg/pull/6073#discussion_r1014895276
########## core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java: ########## @@ -222,8 +222,8 @@ public static LoadTableResponse createTable( throw new IllegalStateException("Cannot wrap catalog that does not produce BaseTable"); } - public static void dropTable(Catalog catalog, TableIdentifier ident) { - boolean dropped = catalog.dropTable(ident); + public static void dropTable(Catalog catalog, TableIdentifier ident, boolean purge) { + boolean dropped = catalog.dropTable(ident, purge); Review Comment: The `SessionCatalog` API requires specifying purge. But the `RESTCatalog` adapter does call `Catalog.dropTable` to have the same behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org