nastra commented on code in PR #6073:
URL: https://github.com/apache/iceberg/pull/6073#discussion_r1008117319
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -320,7 +321,10 @@ public <T extends RESTResponse> T handleRequest(
case DROP_TABLE:
{
- CatalogHandlers.dropTable(catalog, identFromPathVars(vars));
+ CatalogHandlers.dropTable(
+ catalog,
+ identFromPathVars(vars),
+ PropertyUtil.propertyAsBoolean(vars, "purgeRequested", false));
Review Comment:
we're passing `false` here if `purgeRequested` wasn't provided, but
previously data was always purged due to `Catalog.dropTable(ident)` always
using `purge=false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
