RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4458212276
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -664,31 +729,62 @@ public static GetID reassignConflictingIds(Set<Integer>
conflictingIds, Set<Inte
private static class ReassignConflictingIds implements GetID {
private final Set<Integer> conflictingIds;
private final Set<Integer> allUsedIds;
+ private final Set<Integer> claimedIds;
private final AtomicInteger nextId;
private ReassignConflictingIds(Set<Integer> conflictingIds, Set<Integer>
allUsedIds) {
this.conflictingIds = conflictingIds;
this.allUsedIds = allUsedIds;
+ this.claimedIds = Sets.newHashSet();
Review Comment:
Yeah I think that's fine. I'm mostly just worry about these because they
part of our public API. Throwing is perfectly fine response though for external
users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
