RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4382494981
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -460,6 +461,25 @@ public static Type assignIds(Type type, GetID getId) {
return TypeUtil.visit(type, new AssignIds(getId));
}
+ /**
+ * Returns the type to use for a field that was assigned {@code newId}.
+ *
+ * <p>A file's nested field IDs are derived from the ID of the field that
holds it, so a file is
+ * rebuilt from the new ID rather than reassigned field by field.
+ *
+ * @param original the field's type before IDs were assigned
+ * @param newId the ID assigned to the field
+ * @param assignedType the original type with IDs assigned
+ * @return the type the field should have
+ */
+ static Type applyAssignedId(Type original, int newId, Type assignedType) {
Review Comment:
Yep definitely, I think this was left over from an earlier refactor I did
before I stripped out the "original" usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
