RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4382439292
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -67,7 +67,8 @@ public class Schema implements Serializable {
Type.TypeID.VARIANT, 3,
Type.TypeID.UNKNOWN, 3,
Type.TypeID.GEOMETRY, 3,
- Type.TypeID.GEOGRAPHY, 3);
+ Type.TypeID.GEOGRAPHY, 3,
+ Type.TypeID.FILE, 4);
Review Comment:
Yep, I intentionally broke the original PR into what I hoped were
self-contained chunks. Part 2 (of 8) handles reserving the derived ID block: it
adds the base ID validation in `Schema` and forwards `get(oldId, numReserved)`
through the `reassignIds` wrapper, with tests for both cases.
In this PR a file column can't leave the API module: `SchemaParser` doesn't
know the type until part 3, so no table metadata can contain one yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
