RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4382477348
##########
api/src/main/java/org/apache/iceberg/types/AssignIds.java:
##########
@@ -31,8 +31,8 @@ class AssignIds extends
TypeUtil.CustomOrderSchemaVisitor<Type> {
this.getID = getID;
}
- private int idFor(int id) {
- return getID.get(id);
+ private int idFor(int id, Type type) {
+ return type.isFileType() ? getID.get(id, Types.FileType.NUM_NESTED_FIELDS)
: getID.get(id);
Review Comment:
Good idea, let me do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
