RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4448073533
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -753,6 +849,15 @@ public T variant(Types.VariantType variant) {
throw new UnsupportedOperationException("Unsupported type: variant");
}
+ /**
+ * Handles a file type, by default as the struct of its nested fields.
+ *
+ * <p>Override this to distinguish a file from a struct.
+ */
+ public T file(Types.FileType file, List<T> fieldResults) {
Review Comment:
We talked about this before and the basic question is, "Should you be
allowed to look at file metadata without pulling the file bytes?" If the answer
is "yes" then "Inline" must be prunable. So for example, if we want
`SELECT file.content_type FROM Table` to be possible without reading every
inlined byte, we need to be able to prune.
I'm open to other opinions but I think we want to support pruning various
bits out of the File in isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
