danielcweeks commented on code in PR #17116:
URL: https://github.com/apache/iceberg/pull/17116#discussion_r3539946056
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetrics.java:
##########
@@ -66,43 +67,64 @@
class ParquetMetrics {
private ParquetMetrics() {}
- static Metrics metrics(
+ static Iterable<FieldMetrics<?>> fieldMetrics(
Schema schema,
MessageType type,
MetricsConfig metricsConfig,
ParquetMetadata metadata,
Stream<FieldMetrics<?>> fields) {
- long rowCount = 0L;
- Map<Integer, Long> columnSizes = Maps.newHashMap();
Review Comment:
We're doing multiple passes now. Not really a performance concern, but
might be more intuitive as a single pass. Just a thought, not a concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
