danielcweeks commented on code in PR #17116:
URL: https://github.com/apache/iceberg/pull/17116#discussion_r3539935577
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetrics.java:
##########
@@ -409,8 +428,8 @@ public Iterable<FieldMetrics<ByteBuffer>> variant(
fieldId,
metadataCounts.valueCount(),
metadataCounts.nullCount(),
- ParquetVariantUtil.toByteBuffer(metadata, lowerBounds),
Review Comment:
There's no more usage of `ParquetVariantUtil.toByteBuffer(VariantMetadata,
VariantValue)` after removing this.
Since there's no remaining usage should we remove the dead code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
