rdblue commented on code in PR #17116:
URL: https://github.com/apache/iceberg/pull/17116#discussion_r3532152891
##########
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##########
@@ -166,22 +166,20 @@ public void testMetricsForRepeatedValues() throws
IOException {
record.setField("timestampColBelowEpoch",
DateTimeUtil.timestampFromMicros(0L));
Metrics metrics = getMetrics(SIMPLE_SCHEMA, record, record);
- MetricsWithStats metricsWithStats =
- new MetricsWithStats(metrics, MetricsUtil.fromMetrics(SIMPLE_SCHEMA,
metrics));
Review Comment:
The substantive change to these tests is to stop converting metrics to
content stats and validating both. All of the validations are the same. We just
don't need to validate the translation from metrics maps to content stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
