rdblue commented on code in PR #17116:
URL: https://github.com/apache/iceberg/pull/17116#discussion_r3532165215
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetrics.java:
##########
@@ -149,8 +175,7 @@ static Metrics metrics(
originalTypes);
}
- private static class MetricsVisitor
- extends TypeWithSchemaVisitor<Iterable<FieldMetrics<ByteBuffer>>> {
+ private static class MetricsVisitor extends
TypeWithSchemaVisitor<Iterable<FieldMetrics<?>>> {
Review Comment:
The main change to this visitor is the return type. The visitor used to
convert each field's bounds to `ByteBuffer`, but now that is done in the method
that translates `FieldMetrics` to metrics maps. That makes it possible to reuse
this visitor for both metrics maps and v4 content stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
