gaborkaszab commented on code in PR #14035:
URL: https://github.com/apache/iceberg/pull/14035#discussion_r2340178014
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -425,10 +429,23 @@ public <T extends RESTResponse> T handleRequest(
case LOAD_TABLE:
{
- LoadTableResponse resp = CatalogHandlers.loadTable(catalog,
tableIdentFromPathVars(vars));
+ TableIdentifier ident = tableIdentFromPathVars(vars);
- responseHeaders.accept(
- ImmutableMap.of(HttpHeaders.ETAG,
ETagProvider.of(resp.metadataLocation())));
+ LoadTableResponse resp = CatalogHandlers.loadTable(catalog, ident);
Review Comment:
If I rename this then it won't be inline with the naming in other cases.
These were added with my previous
[PR](https://github.com/apache/iceberg/pull/12194).
So my question is: should I rename all the occurrences (then it would be
kind of a noise to this PR), or should I rename this one (it would be
inconsistent with others), or should I leave it as it is ?:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
