amogh-jahagirdar commented on code in PR #14035:
URL: https://github.com/apache/iceberg/pull/14035#discussion_r2341028141
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -425,10 +429,23 @@ public <T extends RESTResponse> T handleRequest(
case LOAD_TABLE:
{
- LoadTableResponse resp = CatalogHandlers.loadTable(catalog,
tableIdentFromPathVars(vars));
+ TableIdentifier ident = tableIdentFromPathVars(vars);
- responseHeaders.accept(
- ImmutableMap.of(HttpHeaders.ETAG,
ETagProvider.of(resp.metadataLocation())));
+ LoadTableResponse resp = CatalogHandlers.loadTable(catalog, ident);
Review Comment:
I see, I think in this case I'd prefer to rename for just this one and
cleanup the naming for the other occurrences in a separate PR since typically
in the project we try not to use shortcut variable names. More of a preference,
not a strict stance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
