gaborkaszab commented on code in PR #14035: URL: https://github.com/apache/iceberg/pull/14035#discussion_r2337040552
########## api/src/main/java/org/apache/iceberg/exceptions/NotModifiedException.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.exceptions; + +import com.google.errorprone.annotations.FormatMethod; + +/** Exception to indicate that resource is unchanged. */ +public class NotModifiedException extends RESTException { Review Comment: One more thought: This PR was meant to focus on the server side implementation of sending 304. What we are discussing now is more about how the client should handle such a response and I was going to take care of that in a follow-up PR. The overlap is that the TableErrorHandler is used both in `RESTCatalogAdapter.handleRequest()` to give error from the server, and also on the `HTTPClient.execute()` side on the client to throw exceptions based on the received responses. I admit my client-side follow-up PoC catches NotModifiedException on the `RESTSessionCatalog.loadTable()` side, but I can adjust that to get null if the table is not changed. But still we'd need this `NotModifiedException` for the server side if I'm not mistaken. Update: Well, taking a second look, maybe I can construct a response without the exception too. Is your point that we can implement this without the exception on the server-side too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
