ronkapoor86 commented on code in PR #14108:
URL: https://github.com/apache/iceberg/pull/14108#discussion_r2361343079
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2645,4 +2645,50 @@ public boolean matches(RewriteFileGroup argument) {
return groupIDs.contains(argument.info().globalIndex());
}
}
+
+ @TestTemplate
+ public void testZOrderWithDateColumn() {
+ spark.conf().set("spark.sql.ansi.enabled", "false");
Review Comment:
Yep i see that. Are you commenting on the false setting, as your added the
PR change?
I agree with your previous image, in that point 1 shouldnt even being
happening the context of maintenance, so its not relevant. I removed the false
flag and with this straightforward unit UDF test it doesn't complain. I just
rebuilt the jar again using my PR without the
spark.conf().set("spark.sql.ansi.enabled", "false"); and it works fine. It
seems as if it was a red herring.
@RussellSpitzer feel free to take a look at the updated PR
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2645,4 +2645,50 @@ public boolean matches(RewriteFileGroup argument) {
return groupIDs.contains(argument.info().globalIndex());
}
}
+
+ @TestTemplate
+ public void testZOrderWithDateColumn() {
+ spark.conf().set("spark.sql.ansi.enabled", "false");
Review Comment:
Yep i see that. Are you commenting on the false setting, as you added the PR
change?
I agree with your previous image, in that point 1 shouldnt even being
happening the context of maintenance, so its not relevant. I removed the false
flag and with this straightforward unit UDF test it doesn't complain. I just
rebuilt the jar again using my PR without the
spark.conf().set("spark.sql.ansi.enabled", "false"); and it works fine. It
seems as if it was a red herring.
@RussellSpitzer feel free to take a look at the updated PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
