ronkapoor86 commented on code in PR #14108:
URL: https://github.com/apache/iceberg/pull/14108#discussion_r2369734929
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderUDF.java:
##########
@@ -310,7 +310,8 @@ Column sortedLexicographically(Column column, DataType
type) {
} else if (type instanceof TimestampType) {
return longToOrderedBytesUDF().apply(column.cast(DataTypes.LongType));
} else if (type instanceof DateType) {
- return longToOrderedBytesUDF().apply(column.cast(DataTypes.LongType));
+ return longToOrderedBytesUDF()
+
.apply(org.apache.spark.sql.functions.unix_date(column).cast(DataTypes.LongType));
Review Comment:
Good call, ill edit add that. Would make the code cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
