Ferdinanddb commented on code in PR #14108:
URL: https://github.com/apache/iceberg/pull/14108#discussion_r2360961259
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2645,4 +2645,50 @@ public boolean matches(RewriteFileGroup argument) {
return groupIDs.contains(argument.info().globalIndex());
}
}
+
+ @TestTemplate
+ public void testZOrderWithDateColumn() {
+ spark.conf().set("spark.sql.ansi.enabled", "false");
Review Comment:
Quick question: why are you setting `spark.sql.ansi.enabled` to `false`?
I did not try to enable it in your test case but I don't have any error when
I run the maintenance procedure locally with the change in
`SparkZOorderUDF.java` and with `spark.sql.ansi.enabled` set to `true`.
This parameter is set to `true` by default in Spark and is quite important
as it can silently set some values to NULL instead of raising an exception in
situations like integer overflow errors. See
[here](https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html) for
more details.
But you might have a good reason of setting it to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
