ronkapoor86 commented on code in PR #14108:
URL: https://github.com/apache/iceberg/pull/14108#discussion_r2360643032
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2645,4 +2645,50 @@ public boolean matches(RewriteFileGroup argument) {
return groupIDs.contains(argument.info().globalIndex());
}
}
+
+ @TestTemplate
Review Comment:
Thanks, ill move the tests further up next to the rest of the tests. And
regarding the extensiveness, yeah that makes sense. All of them are probably
unnecessary. So to clarify, 1 unit test directly on the UDF and 1 integration
test would probably be right? Or just a direct unit test on the UDF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
