nastra commented on code in PR #14108:
URL: https://github.com/apache/iceberg/pull/14108#discussion_r2363020061


##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2110,6 +2113,29 @@ public void testExecutorCacheForDeleteFilesDisabled() {
         .isFalse();
   }
 
+  @TestTemplate
+  public void testZOrderUDFWithAllDataTypes() {

Review Comment:
   is this one supposed to be failing without the fix (it passes for me 
locally)? Also I think there should be some assertions that make sure correct 
return types and such are produced



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to