emkornfield commented on code in PR #1617:
URL: https://github.com/apache/iceberg-rust/pull/1617#discussion_r2289774748
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -378,7 +378,24 @@ impl ArrowSchemaVisitor for ArrowSchemaConverter {
DataType::Int8 | DataType::Int16 | DataType::Int32 => {
Ok(Type::Primitive(PrimitiveType::Int))
}
+ // Cast unsigned types based on bit width (following Python
implementation)
Review Comment:
```suggestion
// Cast unsigned types based on bit width to allow for no data
loss
```
I'm sure python compatibility is a direct goal here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
