emkornfield commented on code in PR #1617:
URL: https://github.com/apache/iceberg-rust/pull/1617#discussion_r2294673331
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -1717,6 +1734,60 @@ mod tests {
}
}
+ #[test]
Review Comment:
Thanks, from the original issue it seems scope is ambiguous. It seems like
this change it makes it possible to create a schema from arrow with unsigned
types which might be helpful by itself, but imagine the next thing the user
would want to do is actually the write the data?
It seems fine to check this in separately as long as there is a clean
failure for the unsigned types (i.e. we don't silently lose data).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
