CTTY commented on PR #1617: URL: https://github.com/apache/iceberg-rust/pull/1617#issuecomment-3208490502
I have the same concern as @emkornfield , using `doc` to determine field type seems unsafe to me. I think casting the type should be fine. This way there would be type loss when converting Iceberg schema back to arrow schema but it should be ok. Also the [Python's implementation](https://github.com/apache/iceberg-python/blob/bdf19ab283f178e54f1647009ec589e6e1839888/pyiceberg/io/pyarrow.py#L1308-L1316) can serve as a good reference. Note that Pyiceberg use bid width while arrow-rs only provides [`primitive_width()`](https://arrow.apache.org/rust/arrow/datatypes/enum.DataType.html#method.primitive_width) that returns width in bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
