emkornfield commented on PR #1617: URL: https://github.com/apache/iceberg-rust/pull/1617#issuecomment-3208074283
Sorry, new to reviewing (and mostly new to the code base) so take comments with a grain of salt, but this approach seems brittle: 1. What happens if someone updates the doc field that removes the type information and Arrow RS tries to read the back? 2. What happens if a non-Arrow RS tries to read data written from Arrow with these fields (in particular int32 and int64)? It seems a more robust solution would be to: 1. Convert uint32->int64 2. Either still block uint64, convert uint64 to a Decimal with an appropriate precision to represent the full range, or use int64 and validate that no values written are outside the appropriate range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
