CTTY commented on code in PR #1617:
URL: https://github.com/apache/iceberg-rust/pull/1617#discussion_r2294589109
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -1717,6 +1734,60 @@ mod tests {
}
}
+ #[test]
Review Comment:
I think writing record batches that contain unsigned types is out of the
scope of the original issue and can be tricky:
- `ParquetWriter` uses `AsyncArrowWriter` under the hood
- `AsyncArrowWriter` uses an arrow schema that got converted from the
Iceberg table schema
- When converting an Iceberg schema to arrow schema, arrow schema won't have
any unsigned types (and I don't think it makes sense to do so unless there is a
valid use case)
- Schema mismatch between record batches and the arrow schema, arrow writer
will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
