dramaticlly commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2240659425
##########
core/src/test/java/org/apache/iceberg/TestCreateTransaction.java:
##########
@@ -211,7 +211,7 @@ public void testCreateDetectsUncommittedChange() throws
IOException {
assertThatThrownBy(txn::newDelete)
.isInstanceOf(IllegalStateException.class)
- .hasMessage("Cannot create new DeleteFiles: last operation has not
committed");
+ .hasMessage("Cannot create new StreamingDelete: last operation has not
committed");
Review Comment:
I tried to use interface class name for operation but some exception case
such as
[CherryPickOperation](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/CherryPickOperation.java)
from manageSnapshots will not have interface name. So I fall back to class
name only when interface name is not available and it seem to be consistent
with original behavior (hardcoded string name before this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
