rdblue commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2240568604
##########
core/src/test/java/org/apache/iceberg/TestCreateTransaction.java:
##########
@@ -211,7 +211,7 @@ public void testCreateDetectsUncommittedChange() throws
IOException {
assertThatThrownBy(txn::newDelete)
.isInstanceOf(IllegalStateException.class)
- .hasMessage("Cannot create new DeleteFiles: last operation has not
committed");
+ .hasMessage("Cannot create new StreamingDelete: last operation has not
committed");
Review Comment:
This may not be a huge problem because it is unlikely, but the error message
is confusing because "streaming" in the context of the delete operation doesn't
mean what people probably think of today.
I think that this should rename `StreamingDelete` to `RemoveFiles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
