dramaticlly commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2240568005
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +121,148 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected <T extends PendingUpdate> T appendUpdates(T update) {
+ checkLastOperationCommitted(update.getClass().getSimpleName());
+
+ if (update instanceof SnapshotUpdate) {
+ ((SnapshotUpdate) update).deleteWith(enqueueDelete);
+ }
+
+ if (update instanceof SnapshotProducer) {
+ ((SnapshotProducer) update).reportWith(reporter);
+ }
+
+ this.updates.add(update);
+ return update;
+ }
+
+ protected void checkLastOperationCommitted(String operation) {
Review Comment:
I agreed, derived class can override `appendUpdate` instead and we can keep
this private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
