rdblue commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2237941177
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +125,143 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected PendingUpdate appendUpdates(PendingUpdate update) {
+ if (!(update instanceof ManageSnapshots)) {
+ checkLastOperationCommitted(update.getClass().getSimpleName());
Review Comment:
Is this conditional on the instanceof check just to handle the
`manageSnapshots` case? If so, we could just validate that the last operation
committed twice and avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
