RussellSpitzer commented on code in PR #13631:
URL: https://github.com/apache/iceberg/pull/13631#discussion_r2243358407
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -121,180 +121,130 @@ public TableOperations underlyingOps() {
return ops;
}
- private void checkLastOperationCommitted(String operation) {
+ protected <T extends PendingUpdate> T appendUpdate(T update) {
Review Comment:
I am not strongly opinionated on this but I'm wondering if we should also
make this final as this is essentially a utility we want subclasses to use but
I'm not sure we want them to be able to override it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
