rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229488936
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java:
##########
@@ -113,6 +145,92 @@ protected boolean supportsRowLineage() {
@TempDir protected Path temp;
+ private static final Type[] SIMPLE_TYPES =
+ new Type[] {
+ Types.UnknownType.get(),
+ Types.BooleanType.get(),
+ Types.IntegerType.get(),
+ LongType.get(),
+ Types.FloatType.get(),
+ Types.DoubleType.get(),
+ Types.DateType.get(),
+ Types.TimeType.get(),
+ Types.TimestampType.withZone(),
+ Types.TimestampType.withoutZone(),
+ Types.TimestampNanoType.withZone(),
+ Types.TimestampNanoType.withoutZone(),
+ Types.StringType.get(),
+ Types.FixedType.ofLength(7),
+ Types.BinaryType.get(),
+ Types.DecimalType.of(9, 0),
+ Types.DecimalType.of(11, 2),
+ Types.DecimalType.of(38, 10),
+ Types.VariantType.get(),
+ Types.GeometryType.crs84(),
+ Types.GeometryType.of("srid:3857"),
+ Types.GeographyType.crs84(),
+ Types.GeographyType.of("srid:4269"),
+ Types.GeographyType.of("srid:4269", EdgeAlgorithm.KARNEY),
Review Comment:
For these tests, just one `geometry` and one `geography` case is sufficient.
I'd use `GeometryType.crs84()` and `GeographyType.crs84()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
