rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229367110
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetReaders.java:
##########
@@ -497,6 +513,28 @@ protected MapData buildMap(ReusableMapData map) {
}
}
+ /** Variant reader to convert from Variant to Spark VariantVal */
+ private static class VariantReader
+ extends ParquetVariantReaders.DelegatingValueReader<Variant, VariantVal>
{
Review Comment:
Style: I usually prefer to import the static class rather than use the full
name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
