rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229416957


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -184,6 +184,8 @@ private static String convertToTypeString(Type type) {
         final Types.MapType mapType = type.asMapType();
         return String.format(
             "map<%s,%s>", convert(mapType.keyType()), 
convert(mapType.valueType()));
+      case VARIANT:
+        return "variant";

Review Comment:
   I confirmed with @aihuaxu that this is not needed. Let's remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to